Skip to content

Update api reference docs for links: part 1 - #12819

Merged
jerelmiller merged 53 commits into
release-4.0from
jerel/more-link-docs
Aug 5, 2025
Merged

Update api reference docs for links: part 1#12819
jerelmiller merged 53 commits into
release-4.0from
jerel/more-link-docs

Conversation

@jerelmiller

Copy link
Copy Markdown
Member

No description provided.

@jerelmiller
jerelmiller requested a review from phryneas July 31, 2025 23:49
@jerelmiller
jerelmiller requested a review from a team as a code owner July 31, 2025 23:49
@changeset-bot

changeset-bot Bot commented Jul 31, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6e272c1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread docs/source/_sidebar.yaml

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize

@pkg-pr-new

pkg-pr-new Bot commented Jul 31, 2025

Copy link
Copy Markdown
npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12819

commit: 6e272c1


For each query, the `http` field is used to modify each individual query in the batch, such as persisted queries (see below).

### Persisted queries

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this section because 1) its not in HttpLink documentation 2) it feels random and 3) we should make sure PersistedQueryLink is used instead since it moves these levers. I don't think we want people manually settings these outside of PersistedQueryLink, at least for the purposes of persisted queries since there are a lot of details to get right outside of just sending extensions and not queries.

Comment thread docs/source/api/link/apollo-link-client-awareness.mdx Outdated
@apollo-librarian

apollo-librarian Bot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-4.0 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch version-2.6
  • !docs set-base-branch main

Build ID: 69099f2cdfbb9e2727bf8e5e
Build Logs: View logs

All error types inherit the `name`, `message`, and nullable `stack` properties from the generic javascript [Error](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error):
See the documentation on [Identifying error types](../../data/error-handling#identifying-error-types) to learn how to distinguish between the different error types.

```js

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out what this was trying to say. I think it was supposed to be api reference documentation for these types? I linked these out in the table above so I just removed this.

let string = renderDocComment(apiItem.tsdocComment);

string = string.replaceAll(/\{\{(\w+)\}\}/g, (_, variable) => {
string = string.replaceAll(/\\?\{\\?\{(\w+)\\?\}\\?\}/g, (_, variable) => {

@jerelmiller jerelmiller Aug 4, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes the warning in https://github.com/apollographql/apollo-client/actions/runs/16732740917/job/47364457350 by allowing us to escape the curlys when we see this warning. Now the following will also be replaced:

\{\{defaultValue\}\}


#### Retrying failed connections

See the [`graphql-ws` recipes](https://the-guild.dev/graphql/ws/recipes) for strategies on retrying failed connections from the client. We recommend this approach as it provides more detailed information on the reason the connection failed.

@phryneas phryneas Aug 5, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See the [`graphql-ws` recipes](https://the-guild.dev/graphql/ws/recipes) for strategies on retrying failed connections from the client. We recommend this approach as it provides more detailed information on the reason the connection failed.
See the [`graphql-ws` recipes](https://the-guild.dev/graphql/ws/recipes) for strategies on retrying failed connections from the client. We generally recommend this approach over retrying connections from the link chain or your components, as it provides more detailed information on the reason the connection failed.


See the [`graphql-ws` recipes](https://the-guild.dev/graphql/ws/recipes) for strategies on retrying failed connections from the client. We recommend this approach as it provides more detailed information on the reason the connection failed.

You can also handle retries in the link chain in a more generic manner using the [`RetryLink`](./apollo-link-retry) to resend the operation to the terminating link.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can also handle retries in the link chain in a more generic manner using the [`RetryLink`](./apollo-link-retry) to resend the operation to the terminating link.
Alternatively, you can handle retries in the link chain in a more generic manner using the [`RetryLink`](./apollo-link-retry) to resend the operation to the terminating link.

@phryneas phryneas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@github-actions github-actions Bot added the auto-cleanup 🤖 label Aug 5, 2025
@jerelmiller
jerelmiller force-pushed the jerel/more-link-docs branch 2 times, most recently from 90ba396 to ed28279 Compare August 5, 2025 14:47
@jerelmiller
jerelmiller force-pushed the jerel/more-link-docs branch from 201376e to 6e272c1 Compare August 5, 2025 16:17
@jerelmiller
jerelmiller merged commit 7ff548d into release-4.0 Aug 5, 2025
44 checks passed
@jerelmiller
jerelmiller deleted the jerel/more-link-docs branch August 5, 2025 16:37
@github-actions github-actions Bot mentioned this pull request Aug 5, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants